moonchen commented on code in PR #13406: URL: https://github.com/apache/trafficserver/pull/13406#discussion_r3731159807
########## plugins/experimental/rate_limit/sni_selector.cc: ########## @@ -22,6 +22,13 @@ std::atomic<SniSelector *> SniSelector::_instance = nullptr; +// The VC user-arg index, defined in sni_limiter.cc, used to detach an expired queued VC. +extern int gVCIdx; + +// Shared lock (defined in sni_limiter.cc) serializing the queue/slot transactions below +// against the net-thread VCONN_CLOSE handler. +extern std::mutex gQueueMutex; Review Comment: > Could the lock be per-limiter instead of global? I removed the global lock, so the only locking left is per-limiter: the `_queue_lock` and `_active_lock` that `RateLimiter` already had. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
