bryancall commented on code in PR #13550:
URL: https://github.com/apache/trafficserver/pull/13550#discussion_r3786303204
##########
src/api/InkAPI.cc:
##########
@@ -8935,7 +8935,7 @@ TSRPCHandlerDone(TSYaml resp)
{
Dbg(dbg_ctl_rpc_api, ">> Handler seems to be done");
std::lock_guard<std::mutex> lock(::rpc::g_rpcHandlingMutex);
- auto data = *reinterpret_cast<YAML::Node
*>(resp);
+ auto &data = *reinterpret_cast<YAML::Node
*>(resp);
Review Comment:
Good call, done in 776c679. Cast is now `YAML::Node const *` with a `const`
reference, which also documents that `resp` is read only here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
