Copilot commented on code in PR #13553:
URL: https://github.com/apache/trafficserver/pull/13553#discussion_r3787182171
##########
plugins/origin_server_auth/origin_server_auth.cc:
##########
@@ -1179,8 +1179,8 @@ config_reloader(TSCont cont, TSEvent /* event ATS_UNUSED
*/, void *edata)
Dbg(dbg_ctl, "config expiration time for version: %s %s is in the past,
re-checking in 1 minute", s3->versionString(),
config_fname.c_str());
if (s3->incr_conf_reload_count() % 10 == 0) {
- TSError("[%s] tried to reload config automatically but failed, please
try manual reloading the config file: %s",
- PLUGIN_NAME, config_fname.c_str());
+ TSError("[%s] Reloading a stale config file has been failing (%d
attempts): %s", PLUGIN_NAME, s3->incr_conf_reload_count(),
+ config_fname.c_str());
}
Review Comment:
`incr_conf_reload_count()` increments `_conf_reload_count` (post-increment).
Calling it in both the `if` condition and again in the `TSError()` arguments
increments twice on log iterations, which changes the retry counter and prints
a mismatched attempt number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
