brbzull0 commented on code in PR #13543:
URL: https://github.com/apache/trafficserver/pull/13543#discussion_r3802276017
##########
include/iocore/net/NetHandler.h:
##########
@@ -113,30 +116,38 @@ class NetHandler : public Continuation, public
EThread::LoopTailHandler
/// configuration settings for managing the active and keep-alive queues
struct Config {
+ /// Identifies a config value, so an update can name it instead of passing
a pointer.
+ /// @note The underlying type is fixed and must not be narrowed. The index
arrives as
+ /// an untyped event cookie, and a value that wrapped would look like a
valid index.
+ enum class Index : int {
+ MAX_CONNECTIONS_IN,
+ MAX_REQUESTS_IN,
+ DEFAULT_INACTIVITY_TIMEOUT,
+ COUNT ///< Number of config values, not a valid index.
+ };
Review Comment:
i'll be doing some more work here in the short term, I may re-think this.
thanks mate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
