Copilot commented on code in PR #13557: URL: https://github.com/apache/trafficserver/pull/13557#discussion_r3805898668
########## include/proxy/http/HttpSM.h: ########## @@ -429,6 +429,7 @@ class HttpSM : public Continuation, public PluginUserArgs<TS_USER_ARGS_TXN> void do_drain_request_body(HTTPHdr &response); void wait_for_full_body(); + void generate_cache_key(HttpCacheKey *key, URL *url, bool compat = false); Review Comment: The boolean parameter name `compat` is ambiguous (compatibility with what?) and makes call sites harder to read/less self-documenting. Consider renaming it to something specific like `use_compat_key_92`/`is_compat_key_92`, or (even better) take `CompatibilityCacheLookup` and branch internally, to avoid a "boolean trap" at call sites. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
