Copilot commented on code in PR #13573: URL: https://github.com/apache/trafficserver/pull/13573#discussion_r3816543081
########## contrib/docker/ubuntu/resolute/Dockerfile: ########## @@ -0,0 +1,128 @@ +####################### +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor license +# agreements. See the NOTICE file distributed with this work for additional information regarding +# copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software distributed under the License +# is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express +# or implied. See the License for the specific language governing permissions and limitations under +# the License. +# +####################### +FROM ubuntu:resolute AS build-setup + +ARG LLVM_VERSION=22 +ARG BASE=/opt + +RUN apt update \ + && apt upgrade --yes \ + && apt install --no-install-recommends --yes \ + ca-certificates \ + clang-${LLVM_VERSION} \ + clang-tools-${LLVM_VERSION} \ + lld-${LLVM_VERSION} \ + cmake \ + ninja-build \ + libc-ares-dev \ + libsystemd-dev \ + libev-dev \ + libevent-dev \ + zlib1g-dev \ + wget \ + git \ + libtool \ + make \ + pkg-config \ + libpsl-dev \ + libssl-dev \ +# ATS deps + libxml2-dev \ + libjemalloc-dev \ + libhwloc-dev \ + libfmt-dev \ + libpcre2-dev \ + hwloc \ + libbrotli-dev \ + libzstd-dev \ + luajit \ + libluajit-5.1-dev \ + libcap-dev \ + libmagick++-dev \ + libmaxminddb-dev \ + libcjose-dev \ + libcjose0 \ + libjansson-dev \ + && apt clean --yes + +# Set up cc (and optionally c++) to use clang-18 via alternatives Review Comment: The comment says this sets up clang-18, but this Dockerfile is parameterized with LLVM_VERSION=22. Keeping the comment accurate (or parameterized) avoids confusion when LLVM_VERSION changes. This issue also appears on line 77 of the same file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
