Copilot commented on code in PR #13108:
URL: https://github.com/apache/trafficserver/pull/13108#discussion_r3848291651
##########
include/proxy/http/remap/UrlRewrite.h:
##########
@@ -80,13 +80,15 @@ class UrlRewrite
*/
bool load(ConfigContext ctx = {});
+ bool load_table(const std::string &config_file_path, YAML::Node const
*remap_node, ConfigContext ctx = {});
+
Review Comment:
`UrlRewrite.h` now exposes `YAML::Node` in the public API (`load_table` /
`BuildTable`) but the header doesn't declare `YAML::Node`. This will fail to
compile for translation units that include `UrlRewrite.h` without including
yaml-cpp first. Add a forward declaration (or include `<yaml-cpp/yaml.h>`)
before `class UrlRewrite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
