bneradt commented on PR #13516: URL: https://github.com/apache/trafficserver/pull/13516#issuecomment-5416758408
Addressed the review in `490f22e4b0` and rebased the PR onto current `master`. - Restored the full `CONFIG_DESCRIPTORS` loop, reading each current value and writing it back through the matching public API. The setter-only `insert_forwarded` path uses the valid canonical value `none`, and the legacy no-op certificate path is exercised explicitly. - Added the missing `TSHttpTxnConfigStringGet()` cases for supported SSL string overrides. - Made the host-resolution and HTTP-status-list converters null-safe; the restored loop exposed crashes when their default configuration pointers were null. - Updated the stale `OverridableConfigDefs.h` generated-target documentation. - Kept server-match integer clamping; I added the rationale in the inline thread. Verification in `asfats5`: - ATS formatter: passed - Full Fedora build and PR-specific install: passed - `test_api`: 1,465 assertions in 3 test cases passed - ConnectionTracker test: 14 assertions passed - `conf_remap` AuTest: passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
