bneradt commented on PR #13415:
URL: https://github.com/apache/trafficserver/pull/13415#issuecomment-5417299892
@bryancall Thanks for the thorough review. I rebased onto current master and
addressed the requested items:
- `set-body-from-file` now throws on load failure, rejects bodies over
`proxy.config.body_factory.response_max_size`, and has startup-rejection
coverage for both paths.
- Native `set-body` MIME arguments are validated, including ambiguous
unquoted trailing tokens, and empty bodies no longer retain a MIME type
that
can mislabel a fabricated HTML response.
- HRW4U limits `set-body` to REMAP and SEND_RESPONSE, the dead resource
requirements are removed, the docs are reordered and deduplicated, and
`.body_factory_info` handles EOF without a trailing newline.
- The degraded paths now have focused AuTest coverage.
Validation in the `asfats5` container:
- full ATS configure, build, and install
- all 6 `header_rewrite*` AuTests
- `body_factory_content_type`
- all 699 HRW4U tests
I left the `SetBodyFromData` lifetime race unchanged because it predates this
PR and was noted as non-blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
