serrislew commented on code in PR #13593:
URL: https://github.com/apache/trafficserver/pull/13593#discussion_r3875796921
##########
src/proxy/http3/Http3Frame.cc:
##########
@@ -599,10 +599,9 @@ Http3FrameFactory::create_headers_frame(IOBufferReader
*header_block_reader, siz
{
ats_unique_buf buf = ats_unique_malloc(header_block_len);
- int64_t nread;
- while ((nread = header_block_reader->read(buf.get(), header_block_len)) > 0)
{
- ;
- }
+ int64_t const nread = header_block_reader->read(buf.get(), header_block_len);
+
+ ink_release_assert(nread == static_cast<int64_t>(header_block_len));
Review Comment:
new crash path? intended?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
