brbzull0 commented on code in PR #13570: URL: https://github.com/apache/trafficserver/pull/13570#discussion_r3880088450
########## tests/gold_tests/jsonrpc/config_reload_directive_cli.test.py: ########## @@ -0,0 +1,119 @@ +''' +Verify traffic_ctl command line parsing for the reload options that take a +variable number of values, --directive (-D) and --data (-d). + +Options declared with MORE_THAN_ZERO_ARG_N used to consume every remaining +token, so any option written after -D was silently swallowed as a directive +value and never parsed. -D therefore had to be the last option, and -D could +not be combined with -d. These runs assert on the JSONRPC request that +traffic_ctl builds (printed by -f rpc), because the subject under test is the +command line parsing rather than the server side handling of the reload. +''' +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: Docstring-above-license is the established layout in this tree: 470 of the 565 `tests/gold_tests/**/*.test.py` files open with a module docstring before the ASF header, including `traffic_ctl_cold_config.test.py`, which this PR also touches. Keeping the new file consistent with its neighbours rather than diverging for one test. RAT is green on this head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
