cmcfarlen commented on code in PR #13194:
URL: https://github.com/apache/trafficserver/pull/13194#discussion_r3898182751
##########
include/tscore/MatcherUtils.h:
##########
@@ -32,8 +32,9 @@
#pragma once
#include "tscore/ParseRules.h"
-#include "tscore/Result.h"
#include "tscore/ink_inet.h"
+#include "tscore/ink_inet.h"
+#include "tscore/ink_platform.h"
Review Comment:
You should move the "tscore/ink_platform.h" include into the .cc file, not
here.
##########
src/tscore/MatcherUtils.cc:
##########
@@ -144,7 +142,7 @@ unescapifyStr(char *buffer)
if (*read == '%' && *(read + 1) != '\0' && *(read + 2) != '\0') {
subStr[0] = *(++read);
subStr[1] = *(++read);
- *write = static_cast<char>(strtol(subStr, (char **)nullptr, 16));
+ *write = static_cast<char>(strtol(subStr, static_cast<char
**>(nullptr), 16));
read++;
Review Comment:
The better fix is to just drop the cast all together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
