Copilot commented on code in PR #13417: URL: https://github.com/apache/trafficserver/pull/13417#discussion_r3908413047
########## tests/gold_tests/logging/verify_cache_freshness_fields.py: ########## @@ -0,0 +1,81 @@ +''' +Validate the cache freshness fields produced by cache-freshness-fields.test.py. +''' +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +import pathlib +import sys + + +def load_log_entries(log_path: pathlib.Path) -> dict[str, tuple[int, int, str, str]]: + entries: dict[str, tuple[int, int, str, str]] = {} + + for line in log_path.read_text(encoding='utf-8').splitlines(): + uuid, freshness_limit, current_age, cache_result, cache_write_result = line.split() + entries[uuid] = (int(freshness_limit), int(current_age), cache_result, cache_write_result) + + return entries Review Comment: `load_log_entries()` silently overwrites entries if the log contains the same uuid more than once, which can make the test pass even when extra/unexpected log lines are present. It also raises a generic unpacking exception if a line doesn't have exactly 5 fields, which is harder to diagnose from CI logs. Consider validating the field count and rejecting duplicate uuids with a clear error. This issue also appears on line 34 of the same file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
