zwoop commented on code in PR #13204:
URL: https://github.com/apache/trafficserver/pull/13204#discussion_r3917414891


##########
tools/hrw4u/src/hrw_symbols.py:
##########


Review Comment:
   I think there's a use case here as well which slips through:
   
   ```
   cond %{TXN_CLOSE_HOOK}
       rm-destination QUERY
   ```
   
   This produces
   
   ```
   TXN_CLOSE {
       inbound.url.query = "";
   }
   ```
   
   Which is not legal:
   
   ```
   leif@hel ~/apache/reviews/tools/hrw4u ±master⚡ » uv run ./scripts/u4wrh 
/tmp/bar.hrw|  uv run ./scripts/hrw4u
   cond %{TXN_CLOSE_HOOK} [AND]
   <stdin>:2:4: error: inbound.url.query is not available in the TXN_CLOSE 
section
      2 |     inbound.url.query = "";
        |     ^
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to