cmcfarlen commented on PR #13583: URL: https://github.com/apache/trafficserver/pull/13583#issuecomment-5518370300
Both correct, both mine. Fixed in 580b4d13de. **`<limits>`** — dropping `createSpan` removed `swoc/MemSpan.h`, and that was what supplied `<limits>` for `NOT_FOUND`'s `numeric_limits`. Worth being precise about the state: the header still compiles standalone today, through some other transitive path, so nothing is broken right now. That is exactly what makes it worth declaring rather than leaving to luck, since the path that happens to work is not one this header controls. Verified a translation unit including only `tsutil/Metrics.h` compiles before and after. **Unused `cur_off`** — `addBlob()` destructured the packed value and used only the blob half. It now shifts out just the index. No warning locally, but there is no reason to bind a name that is never read. While applying the second one I broke `create()`, which destructures the same expression and does need both halves; caught by the build, repaired before pushing. Full `test_tsutil` (15725 assertions) and `test_records` (294) pass, and the whole tree builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
