masaori335 opened a new pull request, #13645: URL: https://github.com/apache/trafficserver/pull/13645
1. register log fields through a single helper Prevent bugs like 77725182a55f5248d3985d67a617c94478547619 (#13345). Every field registration duplicated an add() to global_field_list and an emplace() into field_symbol_hash, with the symbol spelled out twice. Log::register_field() does both and keys the hash off the field's own symbol, so the list and the hash cannot drift apart. 2. logging: drop the unused copy flag from LogFieldList::add() No caller ever asked for the copying behaviour, and the default of true made the ownership of an added field read as ambiguous at each call site. LogFieldList now unconditionally takes ownership. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
