traeak commented on code in PR #13611:
URL: https://github.com/apache/trafficserver/pull/13611#discussion_r3959467656
##########
src/proxy/http/HttpTransact.cc:
##########
@@ -2582,6 +2582,15 @@ HttpTransact::issue_revalidate(State *s)
return;
}
+ // An object found under the 9.2 key cannot be revalidated conditionally. The
+ // write that would apply a 304 is a create on the canonical key rather than
+ // an update of the legacy vector, so the cache discards it. Ask for the full
+ // response instead, which migrates the object to the canonical key.
+ if (s->state_machine != nullptr &&
HttpSM::should_use_compatibility_cache_key(s->state_machine->compatibility_cache_lookup))
{
+ TxnDbg(dbg_ctl_http_trans, "compatibility key hit, revalidating without
conditional headers");
Review Comment:
better to call the HttpTransactHeaders function to remove IMS headers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
