masaori335 opened a new pull request, #13665:
URL: https://github.com/apache/trafficserver/pull/13665
ast_visitor.py is test-only today, and it cannot reproduce the file it
parsed. Four things are dropped, each of which changes either the emitted .conf
or the location a diagnostic can name.
A span names a file, line and column rather than a line alone. Procedure
inlining splices nodes in from a second file, so a line number can no longer
say where a diagnostic belongs. Node.line is replaced outright rather than kept
as a property over span: nothing outside the tests reads it, and keeping it
would let new code go on producing locations that cannot name their own file.
Comments, because five .conf goldens carry # comments at exact positions.
Parentheses, because a parenthesized factor emits cond %{GROUP}.
Set and iprange operands, which until now both became a bare tuple: `in
[1.2.3.4]` and `in {1.2.3.4}` produced byte-identical ASTs. They are not
interchangeable -- visitor.py emits `lhs (...)` for a set and `lhs {...}` for
an iprange, and only the set path is sandbox-checked. Each keeps the source
text the emitter already uses, so SetValue.raw matches visitor.py's
set_().getText()[1:-1] and IpRangeValue.raw its iprange().getText().
Target.from_dotted guessed a namespace/field split that no caller wanted;
every table lookup matches the whole dotted name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
