bneradt commented on code in PR #13586:
URL: https://github.com/apache/trafficserver/pull/13586#discussion_r3991760366
##########
plugins/experimental/jax_fingerprint/ja4/tls_client_hello_summary.cc:
##########
@@ -23,14 +23,18 @@
*/
#include "ts/ts.h"
-#include <plugin.h>
#include "ja4.h"
#include "tls_client_hello_summary.h"
-#include <openssl/sha.h>
-#include <cstdint>
#include <algorithm>
+#include <cstdint>
+#include <openssl/sha.h>
+
+namespace
+{
+DbgCtl dbg_ctl{"jax_fingerprint"};
+}
Review Comment:
This is already covered: ts/ts.h directly includes tsutil/DbgCtl.h (line 40
in this revision), so DbgCtl and Dbg are declared here. The full build, focused
CTest suites, and JAx AuTest pass in the Fedora container. I am leaving the
include unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
