Copilot commented on code in PR #13672:
URL: https://github.com/apache/trafficserver/pull/13672#discussion_r4001464576
##########
plugins/header_rewrite/header_rewrite_test.cc:
##########
@@ -557,6 +557,15 @@ test_tokenizer()
END_TEST();
}
+ {
+ SimpleTokenizerTest p("{a}%{PATH}");
+ CHECK_EQ(p.get_tokens().size(), 2UL);
+ CHECK_EQ(p.get_tokens()[0], "{a}");
+ CHECK_EQ(p.get_tokens()[1], "%{PATH}");
+
+ END_TEST();
+ }
Review Comment:
This regression test covers only a leading `{`, but the fixed condition also
protects a leading `<`; that input previously evaluated `line[-1]` through the
same path. Add a `<`-leading case as well so the second trigger cannot regress
untested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
