masaori335 commented on code in PR #13674:
URL: https://github.com/apache/trafficserver/pull/13674#discussion_r4003458536
##########
tools/hrw4u/src/symbols.py:
##########
@@ -181,6 +181,8 @@ def resolve_condition(self, name: str, section: SectionType
| None = None) -> tu
def resolve_function(self, func_name: str, args: list[str], strip_quotes:
bool = False) -> str:
with self.debug_context("resolve_function", func_name, args):
+ self._collect_warning(self._sandbox.check_function(func_name))
Review Comment:
The {ERROR: ...} downgrade is pre-existing and not specific to value
functions: _substitute_strings catches every exception, so a denied condition
inside an interpolation ("{inbound.method}") loses its SandboxDenialError type
the same way, and has since before this PR. Outside interpolation both
resolvers propagate to visitStatement's trap(), which sets the sandbox message
correctly. Fixing the interpolation path is a separate change; keeping this PR
to the one-line policy check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
