masaori335 commented on code in PR #13615:
URL: https://github.com/apache/trafficserver/pull/13615#discussion_r4011687802


##########
tests/gold_tests/pluginTest/origin_server_auth/origin_server_auth.test.py:
##########
@@ -68,6 +72,35 @@ def setUpOriginServer(self):
         # add request/response
         self.server.addResponse("sessionlog.log", request_header, 
response_header)
 
+        with open(self.long_gcp_replay, "w", encoding="utf-8") as replay:
+            replay.write(
+                f'''meta:
+  version: "1.0"
+
+sessions:
+- transactions:
+  - client-request:
+      method: "GET"
+      url: /long-gcp-token
+      version: "1.1"
+      headers:
+        fields:
+        - [ uuid, long-gcp-token ]
+        - [ Host, www.example.com ]
+        - [ Authorization, {{ value: "Bearer {self.long_gcp_token}", as: equal 
}} ]

Review Comment:
   IIUC, this line try to check generated `Authorization` header. should it be 
done in `proxy-request` instead of `client-request`?
   
   ```
   - proxy-request
       headers:
         fields:
         - [ Authorization, {{ value: "Bearer {self.long_gcp_token}", as: equal 
}} ]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to