bryancall commented on PR #13671: URL: https://github.com/apache/trafficserver/pull/13671#issuecomment-5674857797
Split into one PR per defect, as requested in review. This PR is superseded by: - #13683: a caller-supplied `RegexMatchContext` ran on a 32 KiB JIT stack, and the JIT stack moves to a pthread key. Fixes #13660. - #13684: a failed recompile left freed memory in the object. - #13685: a copied `Regex` silently changed engine. The fourth defect, making the pcre2 contexts process-wide, is held rather than opened now. It is only safe once the JIT stack is resolved per thread through a callback, which is #13683, so opening it today would mean a PR carrying #13683's commit along for the ride, which is the bundling this split is meant to undo. It goes up as its own PR once #13683 merges. The branch is ready on my fork as `regex-process-wide-contexts`. Applying all four to master reproduces this PR's tree byte for byte in every file it touched, so nothing was dropped in the split. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
