JosiahWI commented on code in PR #13686:
URL: https://github.com/apache/trafficserver/pull/13686#discussion_r4017632069
##########
src/proxy/http/remap/unit-tests/test_PluginFactory.cc:
##########
@@ -395,7 +395,7 @@ SCENARIO("loading plugins", "[plugin][core]")
WHEN("config using nonexisting absolute plugin file name")
{
- fs::path relativeExistingPath = pluginName;
+ fs::path relativeExistingPath = std::move(pluginName);
Review Comment:
Ah, that's a bummer. Can we at least comment our reason for the
inconsistency? It would look very strange, otherwise, and someone might
re-introduce one or the other Coverity warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
