bryancall commented on PR #13685: URL: https://github.com/apache/trafficserver/pull/13685#issuecomment-5686733821
Both points addressed, and thanks for the read. **Comment verbosity.** Cut in 8c76dfb70d, replied in the thread. Same treatment I gave the comment you flagged on #13684. You were right both times: I had put the reasoning in the source where it duplicated the test, instead of in the commit message where it belongs. **Unit test structure.** Agreed, and taking it as the follow-up you suggested rather than growing this PR. `test_Regex.cc` is past 1,300 lines and the split here added to it. I would rather not reorganize it underneath three open PRs that all touch it; once these land I will file an issue proposing the split so the refactor is reviewable on its own. CI was 14/14 on the previous head. The only change since is comments, and `[Regex]` still passes 389 assertions in 19 cases locally; CI is re-running now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
