bneradt commented on PR #13692: URL: https://github.com/apache/trafficserver/pull/13692#issuecomment-5688813124
@bryancall Fixed the blocking key bound in 9a6db9a45d: read_len < buffSize reserves the terminator. A focused ASan test reproduces the stack-buffer-overflow with the previous code and passes with the fix, including 255-, 256-, and 257-byte keys with and without trailing newlines. I also addressed the non-blocking items: - Restored timestamp-gated config reloads and kept missing-file checks within the five-second bucket. A focused test confirms that 100 lookups after a failed read do not reopen the file, readers retain the previous map, and a later detected change reloads successfully. - Clarified that readers see a complete map, initially empty, and documented the body factory's atomic publication of settings and templates. - Guarded /dev/full with access(..., W_OK) and an explicit warning when unavailable. - Documented both healthchecks behavior changes in the PR description. I kept the local return after Fatal. On this branch Fatal is a macro routed through LogMessage::message, which also handles nonfatal severities, so that shared function cannot be marked [[noreturn]]. A dedicated fatal API would be a broader change; the local return keeps the analyzer from following the invalid-descriptor path in this backport. The asfats5 rebuild/install, formatting, all 41 file-copy assertions, config concurrency/reload checks, and all four tls_client_versions subtests passed. The latest commit was amended and pushed with a lease. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
