JosiahWI commented on code in PR #13683:
URL: https://github.com/apache/trafficserver/pull/13683#discussion_r4020690035
##########
tests/gold_tests/pluginTest/regex_remap/regex_remap.test.py:
##########
@@ -123,19 +125,48 @@
tr.Processes.Default.Streams.stdout = "gold/regex_remap_simple.gold"
tr.StillRunningAfter = ts
-# 3 Test - Preserve the original crash guard from #5762. This request must
-# survive resource exhaustion without redirecting, regardless of which matching
-# resource limit is reached (JIT stack, match work, depth, or heap).
-tr = Test.AddTestRun("resource exhaustion does not crash ATS")
+# 3 Test - A 3 KB query redirects. This rule backtracks once per subject
+# character, so it used to exhaust the 32 KB stack PCRE2 falls back to when a
+# match context carries none, and the rule was skipped. The plugin's context
now
+# inherits the shared 1 MB stack, so the rule matches and the redirect fires.
+#
+# This run needs no JIT gate. With JIT the 1 MB stack resolves the subject, and
+# without JIT the interpreter resolves it on the heap, so the redirect is the
+# answer either way. It only demonstrates the fix on a build that has a JIT.
Review Comment:
It's easy - see line 158. But I'm fine with no gate for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
