masaori335 opened a new pull request, #13697:
URL: https://github.com/apache/trafficserver/pull/13697

   `strncasecmp(a, b, n)` is an equality test only when the lengths are 
compared first. Without that, any input that is a prefix of the expected 
literal matches: `Vary: Accept` suppressed the `Vary: Accept-Encoding` compress 
adds, `escape: jsonX` loaded as JSON, and isTrue("1abc") was true. Replace 
these with `ts::iequals`, which short-circuits on a length mismatch.
   
   Prefix and suffix matches keep using `strncasecmp`. StringCompare.h joins 
the installed tsutil headers because plugins now include it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to