masaori335 commented on code in PR #13699:
URL: https://github.com/apache/trafficserver/pull/13699#discussion_r4023165332


##########
tools/hrw4u/src/ast_visitor.py:
##########
@@ -123,6 +126,14 @@ def _visit_function_call(self, ctx) -> FunctionCall:
             args = tuple(self._extract_value(v) for v in 
ctx.argumentList().value())
         return FunctionCall(name=name, args=args, line=ctx.start.line)
 
+    def _extract_assignment_value(self, ctx) -> ValueExpr:
+        # Only an assignment RHS echoes its bool spelling; elsewhere a plain 
bool is enough.
+        if ctx.TRUE():
+            return BoolValue(raw=ctx.TRUE().getText())
+        if ctx.FALSE():

Review Comment:
   
[8eb2e73](https://github.com/apache/trafficserver/pull/13699/commits/8eb2e735576984d8847f80245d127a9e86df3e93)
 introduced `BoolValue`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to