bneradt commented on PR #13409: URL: https://github.com/apache/trafficserver/pull/13409#issuecomment-5736955737
Thanks @masaori335 — I reproduced the exact Fedora error in `asfats5` (Fedora 44, Clang 22) using the pipeline's `ci-fedora-cxx20` preset and amended the fix into 2e38442db0. `get_map()` returned a mutable reference to guarded state despite requiring only a shared lock. It now returns a const reference and is a const member function, matching the status handler's read-only iteration. Thread-safety analysis remains enabled with warnings treated as errors. I also addressed the replay-fixture feedback: the delayed response is now in `hostdb_clear.replay.yaml`, and the shared `single_transaction.replay.yaml` used by `dns_ttl` has its original timing restored. I am retaining per-partition locking for clear. Concurrent DNS resolutions may repopulate a partition once it has been cleared; the operation does not suspend lookups or promise that the cache remains empty under active traffic. Holding all partition locks would create a global pause and still allow repopulation immediately after unlocking, before the RPC response reaches the caller. The zero-items assertion is made with no concurrent population in that test run. A global barrier/generation policy would require a separately defined stronger contract. Validation in `asfats5`: - Full `ci-fedora-cxx20` build and install: passed. - `ctest -j4 --output-on-failure --no-compress-output -T Test`: all 186 tests passed. - `/tmp/ats/bin/traffic_server -K -R 3`: passed. - With AuTest support enabled on the same preset, `hostdb_clear` and `dns_ttl`: both passed, with no skips or warnings. - CMake `format` target and commit formatting checks: passed. The amended branch is pushed. Fresh CI results are still needed before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
