bneradt commented on PR #13653: URL: https://github.com/apache/trafficserver/pull/13653#issuecomment-5764501532
@bryancall Addressed in 6524483c76. Replacement references are now validated during compilation against the pattern's defined capture count. That count is checked for failure and cached for both capture and replacement buffer allocation. Unmatched trailing groups substitute an empty string, and the runtime reference-rejection loop is gone. The replay now covers absent trailing groups, an absent middle group, and all groups participating. Unit coverage also checks that genuinely invalid references fail initialization. Running the new unit tests against the pre-review implementation produces the expected failures for optional groups and invalid references. Validation passed: full build/install and formatting; CTest `pattern_test` and `test_tsutil`; ASan `pattern_test` including twelve-group capture and replacement; and all three AuTests (`cachekey_capture`, `cache_range_requests_cachekey`, and `cache_range_requests_cachekey_global`). The PR description now notes heap allocation for patterns exceeding the inline match buffer. There are no inline review threads to resolve. This addresses the requested change and is ready for another review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
