moonchen commented on code in PR #13380:
URL: https://github.com/apache/trafficserver/pull/13380#discussion_r4067001367
##########
src/iocore/cache/RamCacheLRU.cc:
##########
@@ -230,16 +235,60 @@ RamCacheLRU::put(CryptoHash *key, IOBufferData *data,
[[maybe_unused]] uint32_t
}
}
+ RamCacheLRUEntry *e = bucket[i].head;
Review Comment:
The rebase left two resident-entry loops. This one redeclares `e` (`error:
redeclaration of 'RamCacheLRUEntry* e'`), and with that fixed it's still
unreachable: the loop above from #13669 returns 1 on a resident hit, so the
`copy && !e->copy` refresh never runs and 4 of the 8 `test_RamCacheCopy` cases
fail. Move the refresh into the first loop and drop this one. With that change
the RAM cache tests pass locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
