Copilot commented on code in PR #13711:
URL: https://github.com/apache/trafficserver/pull/13711#discussion_r4074756363
##########
src/records/RecordsConfig.cc:
##########
@@ -1245,6 +1245,9 @@ static constexpr RecordElement RecordsConfig[] =
,
{RECT_CONFIG, "proxy.config.ssl.origin_session_cache.size", RECD_INT,
"10240", RECU_RESTART_TS, RR_NULL, RECC_NULL, nullptr, RECA_NULL}
,
+ {RECT_CONFIG, "proxy.config.ssl.origin_session_cache.max_session_size",
RECD_INT, "8192", RECU_RESTART_TS, RR_NULL,
+ RECC_INT, "[0-65536]", RECA_NULL}
Review Comment:
This `RecordElement` initializer appears to be missing the `nullptr`
argument that other entries include between the `RECC_*` validation fields and
`RECA_NULL` (e.g., the preceding `origin_session_cache.size` entry). As
written, `RECA_NULL` is likely being bound to the wrong struct field (or
leaving a required field defaulted), which can break record
validation/initialization. Add the missing argument so the field ordering
matches the surrounding entries.
##########
tests/gold_tests/tls/tls_origin_session_reuse_large.test.py:
##########
@@ -0,0 +1,145 @@
+'''
+'''
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+Test.Summary = '''
+Origin TLS sessions must still be cached when the serialized session is large.
+
+The origin session cache refuses to store a session whose i2d_SSL_SESSION form
+exceeds SSL_MAX_ORIG_SESSION_SIZE. A serialized session carries the peer
+certificate and the session ticket, so an origin with a large certificate -- or
+any mutual-TLS origin, whose ticket encodes the client certificate -- produces
a
Review Comment:
The test description still states the limit is the fixed
`SSL_MAX_ORIG_SESSION_SIZE`, but this PR makes the ceiling configurable via
`proxy.config.ssl.origin_session_cache.max_session_size` (and the old macro no
longer exists in this diff). Update the test’s summary text to describe the new
configurable behavior (e.g., default ceiling vs. configured ceiling) so the
test remains accurate and easier to understand when debugging failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
