cmcfarlen opened a new pull request, #13718: URL: https://github.com/apache/trafficserver/pull/13718
The non-direct-IO retry added in TS-1312 only fires when O_CREAT is set, and O_CREAT is set only when the span names a directory, so that cache.db can be created inside it. An explicit file span in storage.config therefore gets no retry: on a file system without O_DIRECT support the span open fails outright and the cache is disabled, even though the very same file system works when the span is written as a directory. Whether direct I/O is usable is a property of the file system, not of the form the span was written in. The cache_shm_* autests are the only ones configuring an explicit file span, so on a sandbox whose file system lacks O_DIRECT all of them fail with "must be placed on a file system that supports direct I/O" followed by "Cache Disabled". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
