maskit opened a new pull request, #13728: URL: https://github.com/apache/trafficserver/pull/13728
The ja4_fingerprint and jax_fingerprint plugins map TLS versions to the two-character code in the `a` section of a JA4 fingerprint. Two of the entries don't match the [JA4 spec](https://github.com/FoxIO-LLC/ja4/blob/main/technical_details/JA4.md#tls-and-dtls-version): - The spec says SSL 2.0 is `0x0002` → `s2`. The plugins used `0x0200` → `s2`. - The plugins also mapped `0x0100` → `s1`. The spec has no such entry, so that value should be `00` (unknown). ## Changes - Both plugins map `0x0002` to `s2` and no longer have an `s1` case. `0x0200` and `0x0100` now report `00`. - Unit tests in both plugins expect `0x0002` → `s2` and check that `0x0200` and `0x0100` report `00`. With the old mapping, both `test_ja4.JA4` and `test_jax.JA4` fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
