moonchen commented on PR #13362: URL: https://github.com/apache/trafficserver/pull/13362#issuecomment-5879551284
@saimayithri thanks for investigating this. I filed two issues that could help explain these crashes: - #13743: Certifier calls `TSVConnReenable()` from a task thread. ATS can then hold the connection's NetHandler mutex on that task thread. The connection's own network thread can fail to acquire the mutex, even though it is running on the correct thread. - #13744: If a plugin calls `TSHttpSsnReenable()` from a different network thread, ATS can continue processing the session on that wrong thread. @wuxcer the original report mentions certifier. Could you share the full plugin list? Do any custom plugins call `TSVConnReenable()`, `TSVConnReenableEx()`, or `TSHttpSsnReenable()` from another thread? We reproduced the lock conflict and the wrong-thread session callback separately. We have not confirmed that either caused the reported crashes. My concern with changing the thread during teardown is that earlier code may already have run on the wrong thread. We should find where that first happened. For the TLS issue, teardown may already be on the correct thread, so moving it there would not solve the lock conflict. Could we check these two paths first, then decide where to fix the crash? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
