Copilot commented on code in PR #13447: URL: https://github.com/apache/trafficserver/pull/13447#discussion_r4149468652
########## tests/gold_tests/h2/replay_h2o_pool_reuse/pool_reuse.replay.yaml: ########## @@ -0,0 +1,173 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +meta: + version: '1.0' + +# Five separate H/1 client sessions, each issuing a single request to the +# same origin (matching SNI + IP + cert). This is the production-style +# pattern that exposes the H/2 origin session pooling bug: every new +# client session triggers a fresh `acquire_session` lookup with no +# session attached to the user-agent transaction, so the pool search is +# what determines whether the existing H/2 origin connection is reused. +# If reuse works, all 5 requests should be multiplexed onto a single H/2 +# origin connection (1 connection, 5 streams). + +sessions: + - protocol: + - name: http + version: '1.1' + - name: tcp + - name: ip + version: '4' Review Comment: This replay declares each client session as HTTP/1.1, but it does not provide a `proxy-request.protocol` declaring an HTTP/2 origin connection. The verifier therefore cannot exercise the H2 origin path that this test claims to measure; `total_server_streams` can remain zero while the test either uses HTTP/1.1 or fails protocol negotiation. Add the origin-side HTTP/2 protocol/TLS metadata (as in `replay_h2origin/h1-client-h2-origin.yaml`) to every transaction, or otherwise make the verifier server's origin protocol explicit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
