bneradt commented on code in PR #13780:
URL: https://github.com/apache/trafficserver/pull/13780#discussion_r4161240505
##########
src/proxy/http2/Http2ConnectionState.cc:
##########
@@ -184,9 +184,7 @@ Http2ConnectionState::rcv_data_frame(const Http2Frame
&frame)
return Http2Error(Http2ErrorClass::HTTP2_ERROR_CLASS_NONE);
}
- if (stream->is_read_enabled()) {
- stream->signal_read_event(VC_EVENT_READ_COMPLETE);
- }
+ stream->signal_read_complete();
Review Comment:
Agreed that a deferred pure END_STREAM could be lost, but I went with
@bryancall's approach rather than calling `set_read_done()` here. The stream
now remembers the event itself (`_deferred_read_event`) and `reenable()`
schedules that exact event with `send_tracked_event`, so it no longer depends
on `update_read_request` re-deriving READ_COMPLETE from `nbytes`/`ntodo()`.
That also avoids the zero-length body regression that `set_read_done()` would
introduce on this path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
