masaori335 commented on code in PR #13767:
URL: https://github.com/apache/trafficserver/pull/13767#discussion_r4161389605
##########
src/iocore/cache/StripeSM.cc:
##########
@@ -1338,19 +1338,16 @@ StripeSM::add_writer(CacheVC *vc)
void
StripeSM::shutdown(EThread *shutdown_thread)
{
- // the process is going down, do a blocking call
- // dont release the volume's lock, there could
- // be another aggWrite in progress
- SCOPED_MUTEX_LOCK(lock, this->mutex, shutdown_thread);
+ // Never released, so no writer can add Dir entries after this sync.
+ MUTEX_TAKE_LOCK(this->mutex, shutdown_thread);
Review Comment:
It's merged. No blocker now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
