juanthropic commented on PR #13424: URL: https://github.com/apache/trafficserver/pull/13424#issuecomment-5962779356
> This registers `sort-destination` only in the native plugin. HRW4U has no forward mapping for it, and reverse conversion rejects `sort-destination QUERY` with `Unknown operator: sort-destination` Agreed, this is a gap. Deferring it to a follow-up hrw4u PR that adds `inbound.url.query.sort()` together with `.remove()` and `.keep()`, and deprecates `remove_query()` / `keep_query()`. Adding a flat `sort_query()` here would add a function that the follow-up deprecates right away. > When a remap rule runs `set-destination URL ...` before `sort-destination QUERY`, the first operator replaces the header's URL and invalidates the original URL object Fixed in b60e1728c. `sort-destination` now takes the `!res.changed_url` guard that `set-destination` uses, so it reads the current URL from the header after an earlier URL change. The new E2E session runs `set-destination URL` then `sort-destination QUERY` and aborts ATS without the guard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
