bneradt commented on PR #13748:
URL: https://github.com/apache/trafficserver/pull/13748#issuecomment-6000473024
Thanks @bryancall. Addressed the non-blocking points in e705ed01a8:
- **Allocation failure:** the constructor guards the JIT stack assignment
and the copy, and a non-default `Options` whose context could not be allocated
returns `PCRE2_ERROR_NOMEMORY`, so ESI fails closed.
- **Upgrading note:** added under "Upgrading to ATS v11.x", next to the
`ts::Metrics` entry.
- **JIT-stack test margin:** the subject is now 8000 characters.
- **Exhaustion assertion:** now `PCRE2_ERROR_JIT_STACKLIMIT` exactly, with a
comment on why nothing is asserted without JIT.
- **Future `Options` fields:** `Options` has a defaulted `operator==`, the
default check compares against `Options{}`, and the comment says each field
must be applied on every call.
- **Leftovers:** the no-argument `get_match_context()` is used again by the
default path, the stale `ovector` paragraph is gone from all three `exec` docs,
and the test data is renamed.
I kept the separate 3-argument overload instead of `Options const &opts =
{}`. A default argument of a nested type with default member initializers hits
CWG 1397 and fails to compile inside the enclosing class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
