ezelkow1 commented on PR #13670: URL: https://github.com/apache/trafficserver/pull/13670#issuecomment-6020925171
Minor, non-blocking: the root `CMakeLists.txt` applies the allocator to every target via `link_libraries(jemalloc::jemalloc)` / `link_libraries(mimalloc)` when `ENABLE_JEMALLOC` / `ENABLE_MIMALLOC` is set. With a static jemalloc/mimalloc, `benchmark_Regex_alloc` would end up with two definitions of `malloc`/`free`/etc. (the interposer's and the allocator archive's) and likely fail to link. Shared-library builds are fine since the interposer just shadows the allocator and `RTLD_NEXT` resolves to it. It's an uncommon configuration, so maybe just skip building `benchmark_Regex_alloc` when either option is on, or leave a note in the CMake comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
