maskit commented on code in PR #13799:
URL: https://github.com/apache/trafficserver/pull/13799#discussion_r4200695603
##########
src/iocore/net/SSLUtils.cc:
##########
@@ -219,6 +219,18 @@ ssl_client_hello_callback(const SSL_CLIENT_HELLO
*client_hello)
TLSSNISupport::ClientHello ch = {client_hello};
#endif
+ TLSEventSupport *es = TLSEventSupport::getInstance(s);
+ // The TLS library calls back again once a paused ClientHello hook
reenables, by which time the
+ // ClientHello work and its hooks have run and the hook state has moved on.
Dispatching from
+ // that state would hand the next stage's hooks TS_EVENT_SSL_CLIENT_HELLO.
+ if (es != nullptr && es->finished_client_hello_hooks()) {
+ // Renegotiation carries a new ClientHello, whose SNI actions must still
run.
+ auto *ssl_vc = SSLNetVCAccess(s);
Review Comment:
Hmm, I don't want another call for `SSLNetVCAccess`. It does not work for
QUIC connection. I'd add `getSSLHandShakeComplete` equivalent function to
`TLSBasicSupport`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
