RajaMuhammadAwais commented on PR #13787:
URL: https://github.com/apache/trafficserver/pull/13787#issuecomment-6065526289
Thanks for the detailed review and verification.
I have pushed the follow-up fixes to this PR:
- Updated `splitdns_failover.test.py` to perform multiple lookups so the
dead nameserver is actually exercised, verify failover to the live nameserver,
and verify recovery after the dead nameserver is brought back.
- Added a shared `open_all_rr_cons()` helper so the default DNS handler and
SplitDNS handler use the same round-robin connection initialization logic.
- Removed the redundant `dns_ns_rr_init_down = 0` assignment from SplitDNS
startup.
- Updated the SplitDNS startup comment to clarify that it shares the
round-robin connection pool but does not schedule the default handler’s
periodic retry event.
- Reset `port` for every entry in `ProcessDNSHosts()` so a custom port from
one `named` entry cannot leak into the next entry.
- Corrected the inverted socket validity check in `open_con()`:
`if (!cur_con.sock.is_ok())` → `if (cur_con.sock.is_ok())`.
Validation completed successfully:
- `traffic_server` build
- `splitdns_failover` AuTest
- `splitdns` AuTest
- `splitdns_reload` AuTest
- `git diff --check`
- Python syntax validation for the updated test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
