Copilot commented on code in PR #13801:
URL: https://github.com/apache/trafficserver/pull/13801#discussion_r4230988455
##########
doc/admin-guide/plugins/lua.en.rst:
##########
@@ -4821,6 +4821,7 @@ Http config constants
TS_LUA_CONFIG_WEBSOCKET_NO_ACTIVITY_TIMEOUT
TS_LUA_CONFIG_WEBSOCKET_ACTIVE_TIMEOUT
TS_LUA_CONFIG_HTTP_UNCACHEABLE_REQUESTS_BYPASS_PARENT
+ TS_LUA_CONFIG_HTTP_BYPASS_PARENT
Review Comment:
The docs add `TS_LUA_CONFIG_HTTP_BYPASS_PARENT`, but this PR doesn’t show
the corresponding Lua plugin constant being added/exposed. If Lua constants are
not auto-derived from `TSOverridableConfigKey`, this line will be inaccurate.
Either add the Lua binding/constant in the Lua plugin implementation, or
remove/adjust this doc entry to match the actual exported constants.
##########
tests/gold_tests/parent_proxy/replays/bypass_parent_connect.replay.yaml:
##########
@@ -0,0 +1,78 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#
+# CONNECT requests remapped to the verifier server. The connect-direct.test
rule
+# sets proxy.config.http.bypass_parent, so ATS tunnels straight to the
+# server and the follow-up GET travels through the tunnel. The
+# connect-parent.test rule does not, so ATS sends the CONNECT to the dead
parent
+# and returns a 502.
+#
+
+meta:
+ version: "1.0"
+
+sessions:
+- transactions:
+ - client-request:
+ method: CONNECT
+ version: "1.1"
+ url: connect-direct.test:80
+ headers:
+ fields:
+ - [ Host, connect-direct.test:80 ]
+ - [ uuid, connect-direct ]
+ # The CONNECT itself never reaches the server; ATS answers it once the
+ # tunnel is open.
+ server-response:
+ status: 200
Review Comment:
This transaction’s comment states that the CONNECT is not forwarded to the
origin (ATS responds after the tunnel is established), but the replay still
defines a `server-response` for the CONNECT. This is internally inconsistent
and can make the verifier expect an origin HTTP request that should never
occur. Recommend removing the `server-response` block for the CONNECT
transactions (and rely on the follow-up tunneled GET to prove the tunnel is
established), or adjust the test narrative/expectations so the origin is
expected to receive CONNECT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
