Copilot commented on code in PR #13820:
URL: https://github.com/apache/trafficserver/pull/13820#discussion_r4232209159
##########
src/proxy/http/HttpTransactHeaders.cc:
##########
@@ -125,7 +127,7 @@
HttpTransactHeaders::insert_supported_methods_in_response(HTTPHdr *response, int
const char *methods[] = {
HTTP_METHOD_CONNECT.c_str(), HTTP_METHOD_DELETE.c_str(),
HTTP_METHOD_GET.c_str(), HTTP_METHOD_HEAD.c_str(),
HTTP_METHOD_OPTIONS.c_str(), HTTP_METHOD_POST.c_str(),
HTTP_METHOD_PURGE.c_str(), HTTP_METHOD_PUT.c_str(),
- HTTP_METHOD_PUSH.c_str(), HTTP_METHOD_TRACE.c_str(),
+ HTTP_METHOD_PUSH.c_str(), HTTP_METHOD_QUERY.c_str(),
HTTP_METHOD_TRACE.c_str(),
};
char inline_buffer[64];
Review Comment:
Adding `QUERY` likely pushes the serialized `Allow` value past 64 bytes
(depending on delimiter formatting), which will force heap allocation for
`value_buffer` in more cases. Consider increasing `inline_buffer` (e.g., to
128) to keep common `Allow` values on-stack and avoid extra allocations.
##########
doc/release-notes/whats-new.en.rst:
##########
@@ -107,6 +108,11 @@ Features
* Add an optional ``avg_obj_size`` to ``storage.yaml`` to control the directory
entry sizing.
* The ``proxy.config.http.cache.post_method`` is now an overridable config.
+* The HTTP ``QUERY`` method (draft-ietf-httpbis-safe-method-w-body) is now a
Review Comment:
In RST output, `(draft-ietf-httpbis-safe-method-w-body)` won’t render as a
clickable reference. Consider converting this into an actual link (e.g., inline
external link) so readers can navigate directly to the draft from the release
notes.
##########
tests/gold_tests/autest-site/ats_replay.test.ext:
##########
@@ -162,6 +162,11 @@ def configure_ats(obj: 'TestRun', server: 'Process',
ats_config: dict, dns: Opti
if logging_yaml != None:
ts.Disk.logging_yaml.AddLines(yaml.dump(logging_yaml).split('\n'))
+ # Configure ip_allow.yaml if specified.
+ ip_allow_yaml = ats_config.get('ip_allow_yaml')
+ if ip_allow_yaml is not None:
Review Comment:
This change introduces `is not None` checks next to an existing `!= None`
check. For consistent and idiomatic Python (and to avoid `__eq__` surprises),
update the pre-existing `if logging_yaml != None:` to `if logging_yaml is not
None:` (and keep the rest consistent).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
