brbzull0 commented on PR #13032: URL: https://github.com/apache/trafficserver/pull/13032#issuecomment-6142685706
@cmcfarlen thanks. Two corrections first: - The description said 46 AuTest runs. It is 60 after this push. - The docs promised 75 for any command that cannot finish because a request it depends on failed below the level, but only `--monitor` and `--append` did that. `config reset` (its record lookup), `metric monitor` (a poll) and `config reload --show-details` (its reload request or details fetch) exited 0. They now exit 75 too (26987c6d1a), with AuTest runs for each. We found this in our own review. | Ask | Status | |---|---| | `config reload` and `config status` do not grade the task logs | Follow-up #13832, which lists what needs deciding (a `fail` with no entry at or above the level, `timeout`, sub-task entries, `--count`). The description says so under "What this PR does not do". | | Levels below `warn` act like `warn` | Noted in the `--error-level` docs (26987c6d1a), with the one exception: a handler that sets its errata severity apart from the entries. A new AuTest run checks that `--error-level note` on an already-draining server exits 2, like `warn`. | | Copilot: `INVALID_SEVERITY` collision | No change. The sentinel is `INT32_MIN`, so a server that sends exactly that value prints `Severity(invalid)` instead of `Severity(-2147483648)`. Both grade as the highest level, so the exit status is the same. | | Copilot: docstring before the license header in `jsonrpc_error_stub.py` | Kept. The license text is the standard one, and docstring-first is the usual layout in `tests/gold_tests`. | <details><summary>Layout count</summary> 521 of the 689 `.py` files under `tests/gold_tests` start with the module docstring, 168 with the license comment. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
