cmcfarlen commented on PR #13830: URL: https://github.com/apache/trafficserver/pull/13830#issuecomment-6146068116
This PR adds a second dispatch function call to every event. It has a cost in both size and runtime dispatch(extra function call). I agree with Masaori that this could be done statically without either cost. I'm not convinced a change here is necessary, since the type of the second argument is also dependent on the event passed (some handlers will cast it to something else depending on the event anyway) and I don't think there is any combination of types that will cause the thunk template function to produce different code. The old code comments acknowledge the potential for UB if used outside of the intent, but if every use only passes a handler that is a member of a subclass of Continuation, its gonna be fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
