JakeChampion commented on code in PR #13820:
URL: https://github.com/apache/trafficserver/pull/13820#discussion_r4259751517
##########
src/proxy/http/HttpTransact.cc:
##########
@@ -5819,9 +5819,9 @@ HttpTransact::check_request_validity(State *s, HTTPHdr
*incoming_hdr)
return RequestError_t::UNACCEPTABLE_TE_REQUIRED;
}
- // Require Content-Length/Transfer-Encoding for POST/PUSH/PUT
+ // Require Content-Length/Transfer-Encoding for POST/PUSH/PUT/QUERY
if ((scheme == URL_WKSIDX_HTTP || scheme == URL_WKSIDX_HTTPS) &&
- (method == HTTP_WKSIDX_POST || method == HTTP_WKSIDX_PUSH || method ==
HTTP_WKSIDX_PUT) &&
+ (method == HTTP_WKSIDX_POST || method == HTTP_WKSIDX_PUSH || method ==
HTTP_WKSIDX_PUT || method == HTTP_WKSIDX_QUERY) &&
Review Comment:
These lists aren't the same set today: request validation and HTTP/2 header
framing use POST/PUSH/PUT/QUERY, while Expect: 100-continue handling and the
keep_alive_post_out session check use POST/PUT/QUERY without PUSH
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
