Copilot commented on code in PR #13833:
URL: https://github.com/apache/trafficserver/pull/13833#discussion_r4264089068
##########
tests/gold_tests/h2/http2_rst_stream.test.py:
##########
@@ -18,12 +18,27 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+import re
+
Test.Summary = '''
Abort HTTP/2 connection using RST_STREAM frame.
'''
Test.SkipUnless(Condition.HasOpenSSLVersion('1.1.1'),
Condition.HasProxyVerifierVersion('2.8.0'))
+
+# When the client resets its stream, the origin sees the request only if ATS
finished
+# its TLS handshake with the origin first. In that case the origin answers,
the response
+# has nowhere to go, and ATS resets the origin stream with NO_ERROR after the
origin has
+# already closed it. That is fine. The client's abort must never reset an
origin stream
+# that is still open, which the origin logs as an RST_STREAM followed by that
same stream closing.
+def origin_stream_not_reset():
+ return Testers.ExcludesExpression(
+ r'Received RST_STREAM frame with stream id (\d+),.*HTTP/2 stream is
closed with id: \1\b',
+ 'Server is not affected.',
+ reflags=re.DOTALL | re.MULTILINE)
Review Comment:
`Testers.ExcludesExpression` may not support the `reflags` keyword argument
(many AuTest/Testers matchers take flags positionally or via a different
keyword). If `reflags` isn’t recognized, this will raise at test runtime and
break the suite. Use the parameter name that this matcher actually supports in
this repo (or pass the flags as the supported positional/keyword argument,
consistent with other tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
